Skip to content

Convert code-mirror.yml to 1ES Official Pipeline Template #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Copilot wants to merge 3 commits into from
Closed

Convert code-mirror.yml to 1ES Official Pipeline Template #247

Copilot wants to merge 3 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Dec 10, 2025 •
edited
Loading

Issue describing the changes in this PR

Migrates eng/ci/code-mirror.yml from legacy template to 1ES Official Pipeline Template format, matching the structure of official-build.yml.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Changes:

  • Added 1ESPipelineTemplates/1ESPipelineTemplates repository reference with alias 1ESPipelineTemplates (instead of 1es) to avoid repository alias conflicts with the referenced ci/code-mirror.yml@eng template
  • Changed base template from ci/code-mirror.yml@eng to v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates
  • Configured 1ES-compliant pool: 1es-pool-azfunc with Windows 2022 image
  • Added SDL configuration (SpotBugs disabled, consistent with official-build.yml)
  • Wrapped original code-mirror template within stages parameter
  • Added pr: none trigger exclusion
  • Reorganized structure to match official-build.yml

The pipeline maintains its original code mirroring functionality while now operating within the Microsoft 1ES security and compliance framework. The use of 1ESPipelineTemplates as the repository alias follows the pattern established in release.yml and prevents conflicts when the pipeline references external engineering templates.

Original prompt

On code-mirror.yml, Change the code-mirror.yml to a 1ES template like the official-build.yml

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@torosent
Convert code-mirror.yml to 1ES template format
bd3c1ea 
Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Copilot AI changed the title [WIP] Update code-mirror.yml to use 1ES template Convert code-mirror.yml to 1ES Official Pipeline Template Dec 10, 2025
Copilot AI requested a review from torosent December 10, 2025 17:27
@torosent
Copy link
Member

torosent commented Dec 10, 2025

@copilot Encountered error(s) while parsing pipeline YAML:
A repository already exists with alias 1es
/eng/ci/code-mirror.yml: Object reference not set to an instance of an object.

@torosent
Fix repository alias conflict - use 1ESPipelineTemplates instead of 1es
ff6bb39 
Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 10, 2025

@copilot Encountered error(s) while parsing pipeline YAML:
A repository already exists with alias 1es
/eng/ci/code-mirror.yml: Object reference not set to an instance of an object.

Fixed in ff6bb39. Changed the repository alias from 1es to 1ESPipelineTemplates to avoid conflicts with the ci/code-mirror.yml@eng template which likely already defines a 1es repository internally. This pattern matches the release.yml configuration.

@torosent torosent marked this pull request as ready for review December 10, 2025 17:37
@torosent torosent requested a review from a team as a code owner December 10, 2025 17:37
@jviau
Copy link
Member

jviau commented Dec 10, 2025 •
edited
Loading

@torosent do you know why this is change is being made? code-mirror extends 1ESPT already: https://dev.azure.com/azfunc/internal/_git/engineering?path=/ci/code-mirror.yml. And we want unofficial here, the code-mirror pipeline should be marked as non-production. If it isn't non-production, you can change it to non-prod via product catalog if you are a service admin. https://aka.ms/productcatalog

@torosent
Copy link
Member

torosent commented Dec 10, 2025

@torosent do you know why this is change is being made? code-mirror extends 1ESPT already: https://dev.azure.com/azfunc/internal/_git/engineering?path=/ci/code-mirror.yml. And we want unofficial here, the code-mirror pipeline should be marked as non-production. If it isn't non-production, you can change it to non-prod via product catalog if you are a service admin. https://aka.ms/productcatalog

SFI. This was marked as production

@torosent torosent closed this Dec 10, 2025
jviau
jviau requested changes Dec 10, 2025
View reviewed changes
Copy link
Member

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how code-mirror is intended to be used. I'd like to understand what motivated this change.

@torosent torosent deleted the copilot/update-code-mirror-template branch December 10, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jviau jviau jviau requested changes

+1 more reviewer

@torosent torosent torosent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@torosent torosent

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@torosent @jviau